fix: set proper include and lib paths for building within conda#1125
fix: set proper include and lib paths for building within conda#1125Joao-Dionisio merged 5 commits intoscipopt:masterfrom
Conversation
|
Hey @mdealencar thank you! I'm not a big infrastructure guy, but is this essentially doing the same as #1106 but for conda? |
|
It seems like #1106 left out one assignment of includedirs as a str, which caused the error I observed (and is fixed in this PR). But this PR fixes also a mistake in the actual lib and include paths within the conda environment, which is different on Windows than on POSIX systems. |
There was a problem hiding this comment.
Pull request overview
This PR fixes conda environment path configuration for Windows builds by using the correct Library/include and Library/lib subdirectories within CONDA_PREFIX, as conda on Windows uses a different directory structure than other platforms. The change also ensures includedirs is consistently defined as a list, preventing build failures.
- Platform-specific conda path handling for Windows vs non-Windows systems
- Consistent list format for
includedirsvariable across all platforms
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2 participants
conda on Windows uses
CONDA_PREFIX/Library/{include,lib}instead of theCONDA_PREFIX/{include,lib}previously used insetup.py. This PR checks the system platform and uses the correct paths. Additionally, it makes the variableincludedirsalways a list, which also solves a failure in building.